An organization I worked with partnered with Senator McCain a few years back to make a tribute video for one of his old POW friends from the Hanoi Hilton, and boy oh boy, he was definitely the consummate sailor. His favorite way to address his old war buddies was, "GOD DAMNIT, ________, YOU FUCKIN' SONOFABITCH!!" And hearing stories about him from his friends, particularly about their time spent locked up in Vietnam, I don't think they make stand-up guys like that anymore.
I think the short-fuse and temper that made McCain famous and fun as shit was also his biggest weakness. He was a very emotional person, quick to fight and never forgave. Not that I blame him for his feud with Trump, but a good politician would've taken the high road and made amends. That said, I think it's utterly ridiculous when Trump goes around to veterans' rallies, hugging flags and droning on about how much he loves them, after he used his father's money and connections to dodge the draft and went on record mocking McCain for getting captured during Vietnam...and even more ridiculous when actual combat vets come out to worship him.
But, again, that goes to Trump's abilities as a master showman, and his is one. He is marketing genius and brilliant performer. As far as performance, I'm generally quite pleased with what he's done so far, but none of us should ever be fooled. The only thing Trump truly cares about is Trump.